Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds precommit #5

Merged
merged 13 commits into from
Feb 4, 2025
Merged

Adds precommit #5

merged 13 commits into from
Feb 4, 2025

Conversation

jeanluciano
Copy link
Contributor

@jeanluciano jeanluciano commented Feb 3, 2025 •
edited
Loading

Adds pre-commit hooks and CI workflow for pre-commit. It also fixes mypy errors from the hook

@linear Linear
Copy link

linear bot commented Feb 3, 2025

ENG-1054 Add pre-commit to `prefect-cloud`

  • Add pre-commit as a dev dependency
  • Add .pre-commit-config.yaml with support for:
    • ruff
    • mypy
    • pre commit hooks
    • other???
  • Add static analysis github action that will run pre commit on every PR and merge to main in C

@jeanluciano jeanluciano marked this pull request as draft February 3, 2025 20:46
@jeanluciano jeanluciano marked this pull request as ready for review February 4, 2025 15:45
jakekaplan
jakekaplan approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@jakekaplan jakekaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@jeanluciano jeanluciano merged commit 697b2d0 into main Feb 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakekaplan jakekaplan jakekaplan approved these changes

@chrisguidry chrisguidry Awaiting requested review from chrisguidry chrisguidry is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeanluciano @jakekaplan